feat(REB-289): Add Rylo redirect overlay on translate app#252
Conversation
Blocks the legacy dictionary app at sign.mt with a full-screen, non-dismissible popup that redirects users to rylo.com/sign/translate via a CTA matching the Rylo website (cloud sky background, orange CTA). Web only — skipped on native apps. The CTA logs a rylo_redirect_click analytics event before navigating same-tab. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route the redirect analytics event through GoogleAnalyticsService (new logEvent method reusing its isSupported guard) instead of importing FirebaseAnalytics and duplicating the environment guard in the component. Collapse the redundant URL constant into a single field. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds a new redirect overlay component visible only on non-native platforms, with analytics event logging, conditional ARIA dialog rendering, full-screen styled overlay, and app-level integration. Also updates branding references from Nagish to Rylo in logo and announcement banner components. ChangesRylo Redirect Overlay and Branding
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Swap the cropped cloud asset for the official Rylo hero background image, and split the copy into a bold headline plus a smaller subtitle paragraph. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scss (2)
39-56: ⚡ Quick winRemove unnecessary quotes from font-family declarations.
Stylelint flags the quotes around
'Poppins'on lines 41 and 51 as unnecessary. The CSS specification allows unquoted font-family names when they don't contain spaces or special characters. Removing the quotes addresses the linter warnings.♻️ Proposed fix
font-family: 'Poppins', sans-serif; - font-family: 'Poppins', sans-serif; + font-family: Poppins, sans-serif; font-weight: 600;margin: 0; - font-family: 'Poppins', sans-serif; + font-family: Poppins, sans-serif; font-weight: 400;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scss` around lines 39 - 56, Remove the unnecessary single quotes around the font-family in both .rylo-overlay__title and .rylo-overlay__subtitle; update the declarations from font-family: 'Poppins', sans-serif to font-family: Poppins, sans-serif in the CSS so Stylelint warnings are resolved while keeping the same fallback.Source: Linters/SAST tools
58-86: ⚡ Quick winRemove unnecessary quotes from CTA font-family.
Line 67 has the same unnecessary quotes around
'Poppins'flagged by stylelint on the title and subtitle. Applying the same fix here maintains consistency.♻️ Proposed fix
color: `#191412`; - font-family: 'Poppins', sans-serif; + font-family: Poppins, sans-serif; font-weight: 600;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scss` around lines 58 - 86, The font-family declaration in .rylo-overlay__cta uses unnecessary single quotes around 'Poppins' causing stylelint to flag it; update the font-family in the .rylo-overlay__cta rule to remove the quotes and match the other components (use Poppins, sans-serif) so linting and consistency are preserved.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scss`:
- Around line 39-56: Remove the unnecessary single quotes around the font-family
in both .rylo-overlay__title and .rylo-overlay__subtitle; update the
declarations from font-family: 'Poppins', sans-serif to font-family: Poppins,
sans-serif in the CSS so Stylelint warnings are resolved while keeping the same
fallback.
- Around line 58-86: The font-family declaration in .rylo-overlay__cta uses
unnecessary single quotes around 'Poppins' causing stylelint to flag it; update
the font-family in the .rylo-overlay__cta rule to remove the quotes and match
the other components (use Poppins, sans-serif) so linting and consistency are
preserved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ca09ac1-653b-4ff3-9dd5-12a5589212e8
📒 Files selected for processing (3)
src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.htmlsrc/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scsssrc/assets/rylo-hero-background.webp
🚧 Files skipped from review as they are similar to previous changes (1)
- src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.html
Restore the cloud background and present the redirect as a contained, centered modal card over a dimmed backdrop instead of a full-screen takeover. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scss`:
- Line 31: The background-image in rylo-redirect-overlay.component.scss uses an
absolute root path (/assets/rylo-clouds.webp) which breaks when the app is
served from a subpath; update the background-image declaration in
rylo-redirect-overlay.component.scss (the rule setting background-image) to use
a base-href-safe relative asset URL (e.g., remove the leading slash so it points
to "assets/rylo-clouds.webp" or "./assets/rylo-clouds.webp") so the image
resolves correctly regardless of the app base path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e7f9c3da-9e89-4162-b21f-76b3510c23b4
📒 Files selected for processing (3)
src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.htmlsrc/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.scsssrc/assets/rylo-clouds.webp
🚧 Files skipped from review as they are similar to previous changes (1)
- src/app/components/rylo-redirect-overlay/rylo-redirect-overlay.component.html
Swap the cloud band for a full sky photo as a cover background (no seam) and enlarge the modal card for more presence while keeping it contained. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reduce the dark scrim over the sky photo and add a text shadow for legibility so the clouds match the source image. Update the announcement banner to reference Rylo instead of Nagish. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tone the modal background with a #5d7c93 overlay to match the Rylo steel-blue palette, drop the text shadow, align the CTA to the Rylo orange, and replace the Nagish header logo with the Rylo logo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the redirect overlay from the translate route up to the app root so the popup appears on all pages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
Adds a non-dismissible popup on the translate app (REB-289) that redirects users to Sign Translate by Rylo (
rylo.com/sign/translate) via a CTA. The popup is a centered modal card over a dimmed backdrop, styled in the Rylo palette. Web only — not shown in the native apps. Also updates the header logo and announcement banner to Rylo.Test plan
Summary by CodeRabbit
New Features
Style