feat: add vote for a new threshold - #1084
Merged
Merged
Conversation
ChaoticTempest
requested review from
isSerge,
jakmeier,
ppca,
volovyks and
yvonneanne
July 30, 2026 04:19
…ld_change_via_mpc_governance
ppca
reviewed
Jul 30, 2026
… test_threshold_change_via_mpc_governance
ppca
approved these changes
Jul 30, 2026
ChaoticTempest
enabled auto-merge
July 30, 2026 05:13
ChaoticTempest
disabled auto-merge
July 30, 2026 05:13
…t_threshold_change_via_mpc_governance
…generation in test_threshold_change_via_mpc_governance
yvonneanne
reviewed
Jul 30, 2026
yvonneanne
reviewed
Jul 30, 2026
yvonneanne
reviewed
Jul 30, 2026
yvonneanne
reviewed
Jul 30, 2026
jakmeier
reviewed
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add in the ability to vote for a new threshold. It needs to be at minimum
compute_threshold(participants.len())and at maximumparticipants.len(). Once voted in via prior threshold, it will trigger resharing with the same participant set as the new participant set, just with different threshold.Our devnet is currently at 5 threshold and 12 nodes, so we need to utilize this so we don't end up with split brain. So will need to set new threshold this way.