refactor: extract mpc-chain-hydration - #1065
Open
isSerge wants to merge 6 commits into
Open
Conversation
… `ChainIndexer` trait
isSerge
marked this pull request as ready for review
July 27, 2026 15:24
ChaoticTempest
left a comment
ChaoticTempest
left a comment
Contributor
There was a problem hiding this comment.
the changes for the most part look good to me, but I'm always skittish when we don't have any integration tests. Can we hold moving this to supervisor / chain indexer abstraction until we have a local hydration node testing the whole flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to decouple Hydration chain integration from
mpc-nodeby moving into a separate crate:mpc-chain-hydrationcrate in the workspace, move config, indexer and publisherHydrationIndexerto implementChainIndexertrait and listen toCancellationTokencli/mod.rsto userun_supervised(consistent with other chain integrations)