In-memory secrets policy - #1064
Open
volovyks wants to merge 4 commits into
Open
Conversation
volovyks
requested review from
ChaoticTempest,
isSerge,
jakmeier,
ppca and
yvonneanne
July 27, 2026 14:40
isSerge
approved these changes
Jul 27, 2026
ChaoticTempest
approved these changes
Jul 27, 2026
yvonneanne
approved these changes
Jul 28, 2026
yvonneanne
left a comment
yvonneanne
left a comment
Contributor
There was a problem hiding this comment.
Clear and well-organized doc!
I assume there will be follow-up issues/PRs to enforce it.
Consider adding
- clippy.toml with disallowed_types
- tripwire test by log scanning in integration tests
- gitleaks for Rule 6
ppca
approved these changes
Jul 28, 2026
Contributor
Author
|
@yvonneanne Yes, this would definitely be a couple of PR, probably 1 for each requirement. I've extended the policy with an automation plan. Nice suggestions! |
jakmeier
approved these changes
Jul 30, 2026
jakmeier
left a comment
jakmeier
left a comment
Contributor
There was a problem hiding this comment.
Great initiative to write this down in a doc inside the repo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed a security vulnerability (we are printing the whole key except for 4 characters) in
impl fmt::Debug for SecretKeyand have decided to create a policy for in-memory secret management.Please share your opinions. I'm planning to wrap everything in
SecretStringorSecretBox.The question of "How far we want to go" is open. SKs definitely deserve that. We also have Ts and Ps, URLs (with API keys), technically, even the messages between nodes are secrets.
Other ideas on how we can better protect against unintentional key loss are welcome.