chore: build the contract with rust 1.93 instead of 1.81 - #1062
Merged
Conversation
|
|
Pessina
force-pushed
the
chore/rust-1.93-contract-toolchain
branch
4 times, most recently
from
July 27, 2026 14:45
07c1077 to
cd04e7e
Compare
Pessina
requested review from
ChaoticTempest,
isSerge and
jakmeier
and removed request for
jakmeier
July 27, 2026 15:01
Pessina
force-pushed
the
chore/rust-1.93-contract-toolchain
branch
from
July 27, 2026 15:05
cd04e7e to
a7efd51
Compare
ChaoticTempest
approved these changes
Jul 27, 2026
ChaoticTempest
left a comment
ChaoticTempest
left a comment
Contributor
There was a problem hiding this comment.
Nicely done, didn't think we could bump the rust version without doing all the near dependency changes so this is actually pretty good in the mean time before we upgrade all the deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-contract.shhas pinned Rust 1.81.0 since before edition 2024 existed, and cargo 1.81 cannot parse an edition-2024 manifest anywhere in the workspace, which is what blocks the Midnight integration. This moves the toolchain to 1.93.0, matching #842, and leaves the rest of that modernization there:near-sdkstays at 5.7.0 and no contract source changes.Any rustc past 1.81 emits bulk-memory opcodes that the sandbox
near-workspaces0.16.0 downloads refuses to deploy, so it goes to 0.21.0 with the sandbox pinned to 2.12.0, the first release on protocol 84. That exposed a near-fetch bug where a timed-out status query surfaces as a hard error instead of as pending, whichpoll_statusnow corrects.