Skip to content

core/pane: Add noPadding prop #IX-4308#2589

Merged
nuke-ellington merged 4 commits into
mainfrom
fix/IX-4308-pane-padding-fix
Jun 10, 2026
Merged

core/pane: Add noPadding prop #IX-4308#2589
nuke-ellington merged 4 commits into
mainfrom
fix/IX-4308-pane-padding-fix

Conversation

@dmytro-halimov

@dmytro-halimov dmytro-halimov commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

JIRA Ref: IX-4308
Docs PR: siemens/ix-docs#250

🆕 What is the new behavior?

New prop "noPadding" added to remove inline and bottom padding in the content area of the ix-pane component.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b225a0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@siemens/ix Minor
@siemens/ix-aggrid Major
@siemens/ix-angular Minor
@siemens/ix-docs Minor
@siemens/ix-echarts Major
@siemens/ix-react Minor
@siemens/ix-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new noPadding property to the ix-pane component, allowing the removal of left, right, and bottom padding from the content area. The changes are integrated across Angular, Vue, and Core packages, and include a regression test. The reviewer noted a style guide violation where the new property in pane.tsx lacks a @since tag in its JSDoc, which is required to document the version in which it was introduced.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/core/src/components/pane/pane.tsx
@dmytro-halimov dmytro-halimov changed the title (core/pane): Add noPadding prop core/pane: Add noPadding prop #IX-4308 Jun 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook ready!

Name Link
🔨 Latest commit 71cb944
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a26bf86d67eb8000939a125
😎 Deploy Preview https://deploy-preview-2589--ix-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook ready!

Name Link
🔨 Latest commit 091ea6f
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a26c0df94b7480009153e33
😎 Deploy Preview https://deploy-preview-2589--ix-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for ix-storybook ready!

Name Link
🔨 Latest commit b225a0a
🔍 Latest deploy log https://app.netlify.com/projects/ix-storybook/deploys/6a26c5b5fb34fb0008b1d2a4
😎 Deploy Preview https://deploy-preview-2589--ix-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread packages/core/src/components/pane/test/panes.ct.ts
@nuke-ellington nuke-ellington added this to the 5.1.0 milestone Jun 10, 2026
@nuke-ellington nuke-ellington merged commit a2f425c into main Jun 10, 2026
18 checks passed
@nuke-ellington nuke-ellington deleted the fix/IX-4308-pane-padding-fix branch June 10, 2026 14:32
@github-actions github-actions Bot mentioned this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants