Update conversational design illustrations#256
Conversation
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Linus Schlumberger <linus.schlumberger@siemens.com> Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the starter apps and the MCP server (upgrading references to version 5.0.0 and adding OpenCode and Claude Code configurations), refactors font loading in docusaurus.config.ts to use a style tag with @font-face declarations, and removes the unused @types/rimraf dependency. Additionally, it refactors the VersionSelection component to use IxButton and IxDropdown with improved accessibility, and adds form validation dependencies to the framework starter runtimes. Regarding the feedback, a critical bug was identified in the VersionSelection component’s dropdown event handler. The itemClick event from ix-dropdown provides the clicked item in e.detail rather than e.target. Using e.target causes any click to navigate to the first version in the list. We recommend updating the handler to use (e as CustomEvent).detail to correctly resolve the clicked item.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| const handler = (e: Event) => { | ||
| (e.target as HTMLElement).querySelector<HTMLAnchorElement>('a[href]')?.click(); | ||
| }; |
There was a problem hiding this comment.
In Siemens iX, the itemClick event emitted by ix-dropdown provides the clicked ix-dropdown-item element in the event's detail property (e.detail), while e.target refers to the ix-dropdown element itself.
Using e.target to query the a[href] will always search the entire dropdown and return the first link found (which belongs to the first version in the list). This means clicking any version in the dropdown will always navigate to the first available link.
To fix this, we should query the a[href] from (e as CustomEvent).detail instead of e.target.
| const handler = (e: Event) => { | |
| (e.target as HTMLElement).querySelector<HTMLAnchorElement>('a[href]')?.click(); | |
| }; | |
| const handler = (e: Event) => { | |
| const clickedItem = (e as CustomEvent).detail as HTMLElement; | |
| clickedItem?.querySelector<HTMLAnchorElement>('a[href]')?.click(); | |
| }; |
There was a problem hiding this comment.
please remove the subheading as this is only optional and not part of the brand guidelines. "Choose a suggested prompt....."
There was a problem hiding this comment.
again remove subheading please
There was a problem hiding this comment.
Do you think its clear which is the bot and which is the user without the icons? If you think yes, then no problem.
💡 What is the current behavior?
With the new chatbot components, the illustrations on the conversational design guidelines should also show the new components in their illustrations
GitHub Issue Number: #
🆕 What is the new behavior?
👨💻 Help & support