Skip to content

Update conversational design illustrations#256

Open
kathrinschalber wants to merge 9 commits into
docs/ai-componentsfrom
docs/update-conversational-design
Open

Update conversational design illustrations#256
kathrinschalber wants to merge 9 commits into
docs/ai-componentsfrom
docs/update-conversational-design

Conversation

@kathrinschalber

Copy link
Copy Markdown
Collaborator

💡 What is the current behavior?

With the new chatbot components, the illustrations on the conversational design guidelines should also show the new components in their illustrations

GitHub Issue Number: #

🆕 What is the new behavior?

  • Replaced all chat messages with the user or ai message component
  • Replaced all welcome messages with text from ai ux guidlines.

👨‍💻 Help & support

danielleroux and others added 8 commits May 28, 2026 09:32
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Linus Schlumberger <linus.schlumberger@siemens.com>
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24cd35da-e2f5-4b61-a254-22a8e17178f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/update-conversational-design

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kathrinschalber kathrinschalber marked this pull request as ready for review June 30, 2026 08:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the starter apps and the MCP server (upgrading references to version 5.0.0 and adding OpenCode and Claude Code configurations), refactors font loading in docusaurus.config.ts to use a style tag with @font-face declarations, and removes the unused @types/rimraf dependency. Additionally, it refactors the VersionSelection component to use IxButton and IxDropdown with improved accessibility, and adds form validation dependencies to the framework starter runtimes. Regarding the feedback, a critical bug was identified in the VersionSelection component’s dropdown event handler. The itemClick event from ix-dropdown provides the clicked item in e.detail rather than e.target. Using e.target causes any click to navigate to the first version in the list. We recommend updating the handler to use (e as CustomEvent).detail to correctly resolve the clicked item.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +55 to +57
const handler = (e: Event) => {
(e.target as HTMLElement).querySelector<HTMLAnchorElement>('a[href]')?.click();
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

In Siemens iX, the itemClick event emitted by ix-dropdown provides the clicked ix-dropdown-item element in the event's detail property (e.detail), while e.target refers to the ix-dropdown element itself.

Using e.target to query the a[href] will always search the entire dropdown and return the first link found (which belongs to the first version in the list). This means clicking any version in the dropdown will always navigate to the first available link.

To fix this, we should query the a[href] from (e as CustomEvent).detail instead of e.target.

Suggested change
const handler = (e: Event) => {
(e.target as HTMLElement).querySelector<HTMLAnchorElement>('a[href]')?.click();
};
const handler = (e: Event) => {
const clickedItem = (e as CustomEvent).detail as HTMLElement;
clickedItem?.querySelector<HTMLAnchorElement>('a[href]')?.click();
};

@tokyojen tokyojen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two key points

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the subheading as this is only optional and not part of the brand guidelines. "Choose a suggested prompt....."

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again remove subheading please

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think its clear which is the bot and which is the user without the icons? If you think yes, then no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants