[Feat] Minor Library Improvements#2
Open
ajimae wants to merge 6 commits into
Open
Conversation
- make logging optional and customizable - add missing browser page.pdf() options - add onInitialize function callback - add tests to validate new features
- add github actions test workflows - add gitbub actions release workflows
ajimae
commented
Jan 25, 2026
Comment on lines
+32
to
+39
| - name: Create Release | ||
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| tag_name: v${{ steps.get_version.outputs.PACKAGE_VERSION }} | ||
| name: v${{ steps.get_version.outputs.PACKAGE_VERSION }} | ||
| generate_release_notes: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Author
There was a problem hiding this comment.
I see we already have some way to publish to npm we can instead use it rather than use softprops/action-gh-release@v2 action
ajimae
commented
Jan 25, 2026
| }, | ||
| "peerDependencies": { | ||
| "playwright": ">=1.40.0" | ||
| "playwright": ">=1.50.0" |
Author
There was a problem hiding this comment.
There is a regression in playwright version >=1.51.0 where bundling throws error. Hence we will stick with version v1.50.0 until it is fixed upstream.
- add github actions test workflow - add gitbub actions release workflow
- pass remaining options
Author
|
@sidgaikwad can you take a look at this PR? |
- pass remaining options
- pass remaining options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor improvements on the
papercraftlibraryCompleted Tasks