Make Shutter read the xpm cursors x_hot and y_hot coordinates#813
Merged
Conversation
DarthGandalf
reviewed
May 9, 2026
DarthGandalf
reviewed
May 9, 2026
| #of these values | ||
| $self->{_cursors}{$cname}{'x_hot'} = $self->{_cursors}{$cname}->get_option('x_hot'); | ||
| $self->{_cursors}{$cname}{'y_hot'} = $self->{_cursors}{$cname}->get_option('y_hot'); | ||
| if (!$pixbuf) { |
Member
There was a problem hiding this comment.
here is mix of tabs and spaces
DarthGandalf
reviewed
May 9, 2026
| $self->{_cursors}{$self->{_current_mode_descr}}{'x_hot'}, $self->{_cursors}{$self->{_current_mode_descr}}{'y_hot'}, | ||
| ); | ||
| } | ||
| if (exists $self->{_cursors}{$self->{_current_mode_descr}}) { |
Member
|
Other than whitespaces, looks good |
DarthGandalf
reviewed
May 9, 2026
| $self->{_cursors}{$self->{_current_mode_descr}}{'x_hot'}, $self->{_cursors}{$self->{_current_mode_descr}}{'y_hot'}, | ||
| ); | ||
| } | ||
| my $cursor_data = $self->{_cursors}{$self->{_current_mode_descr}}; |
DarthGandalf
approved these changes
May 9, 2026
Member
Author
|
Should be okay now! I guess, I need to look for a better text editor... |
Member
Nope
in nvim I have this: |
Member
Author
|
Sorry, I merged too fast. What is the best way to fix the last whitespace problem? A new PR? |
Member
|
That works. Dunno if it's the best one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since upstream is irresponsive (see https://gitlab.gnome.org/GNOME/glycin/-/work_items/291), Shutter can now read the coordinates directly from the xpm files. This will fix #808.