Set bucket ip filter #65
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| require_relative "../storage_helper" | ||
| describe Google::Cloud::Storage::Bucket, :storage do | ||
| let(:ip_filter_disabled) do | ||
| { | ||
| mode: "Disabled", | ||
| public_network_source: { | ||
| allowed_ip_cidr_ranges: ["0.0.0.0/0", "::/0"] | ||
| } | ||
| } | ||
| end | ||
|
|
||
| let(:ip_filter_disabled_update) do | ||
| { | ||
| mode: "Disabled", | ||
| public_network_source: { | ||
| allowed_ip_cidr_ranges: ["8.8.8.8/32"] | ||
| }, | ||
| vpc_network_sources: [ | ||
| { | ||
| network: "projects/#{storage.project}/global/networks/default", | ||
| allowed_ip_cidr_ranges: ["0.0.0.0/0"] | ||
| } | ||
| ] | ||
| } | ||
| end | ||
| let(:bucket_name) { "#{$bucket_names.first}-ip-filter" } | ||
| let :bucket do | ||
| storage.bucket(bucket_name, projection: "full") || | ||
| storage.create_bucket(bucket_name, ip_filter: ip_filter_disabled) | ||
| end | ||
|
|
||
| after(:all) do | ||
| safe_gcs_execute { bucket.delete } | ||
| end | ||
|
|
||
| it "returns a 400 error when provided an invalid IP CIDR range" do | ||
| invalid_ip_filter = { | ||
| mode: "Enabled", | ||
| public_network_source: { | ||
| allowed_ip_cidr_ranges: ["invalid-ip-range"] | ||
| } | ||
| } | ||
|
|
||
| # Verify that creating a bucket with an invalid CIDR raises an error | ||
| err = expect { | ||
| storage.create_bucket "#{bucket_name}-invalid", ip_filter: invalid_ip_filter | ||
| }.must_raise Google::Cloud::InvalidArgumentError | ||
|
|
||
| _(err.message).must_match /invalid/i | ||
| end | ||
|
|
||
| it "creates, gets, updates, and deletes a bucket with ip_filter" do | ||
|
|
||
|
|
||
| _(bucket.ip_filter).wont_be_nil | ||
| _(bucket.ip_filter.mode).must_equal "Disabled" | ||
| _(bucket.ip_filter.public_network_source.allowed_ip_cidr_ranges).must_equal ["0.0.0.0/0", "::/0"] | ||
|
|
||
| # Get the bucket and verify ip_filter | ||
| bucket = storage.bucket bucket_name, projection: "full" | ||
| _(bucket.ip_filter).wont_be_nil | ||
| _(bucket.ip_filter.mode).must_equal "Disabled" | ||
| _(bucket.ip_filter.public_network_source.allowed_ip_cidr_ranges).must_equal ["0.0.0.0/0", "::/0"] | ||
|
|
||
| # list_bucket_ip_filters | ||
| found = false | ||
| storage.buckets(projection: "full").all do |b| | ||
| found = true if b.name == bucket_name | ||
| end | ||
| _(found).must_equal true | ||
|
|
||
| # Update the ip_filter | ||
| safe_gcs_execute do | ||
| bucket.update do |b| | ||
| b.ip_filter = ip_filter_disabled_update | ||
| end | ||
| end | ||
|
|
||
| _(bucket.ip_filter.mode).must_equal "Disabled" | ||
| _(bucket.ip_filter.public_network_source.allowed_ip_cidr_ranges).must_equal ["8.8.8.8/32"] | ||
| _(bucket.ip_filter.vpc_network_sources.first.network).must_equal "projects/#{storage.project}/global/networks/default" | ||
| _(bucket.ip_filter.vpc_network_sources.first.allowed_ip_cidr_ranges).must_equal ["0.0.0.0/0"] | ||
|
|
||
| # Disable ip_filter and clear network sources | ||
| safe_gcs_execute do | ||
| bucket.ip_filter = { | ||
| mode: "Disabled", | ||
| public_network_source: { | ||
| allowed_ip_cidr_ranges: [] | ||
| }, | ||
| vpc_network_sources: [] | ||
| } | ||
| end | ||
|
|
||
| _(bucket.ip_filter.public_network_source.allowed_ip_cidr_ranges).must_be_nil | ||
| _(bucket.ip_filter.vpc_network_sources).must_be_nil | ||
|
|
||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ip_filtermetadata is only returned when using thefullprojection (as noted in the samples). If the bucket does not already exist in the project,storage.create_bucketwill be called withoutprojection: "full", meaning the returned bucket object won't haveip_filterpopulated. This will cause the assertion_(bucket.ip_filter).wont_be_nilto fail on a clean run. Addingprojection: "full"tocreate_bucketensures the test is robust and passes on clean runs.