forked from googleapis/google-cloud-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove accept encoding gzip try #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhangi-google
wants to merge
7
commits into
main
Choose a base branch
from
remove_accept_encoding_gzip_try
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ca42944
removing accept encoding header from initialize
shubhangi-google 634e2e0
blank commit
shubhangi-google 4e868e8
blank commit
shubhangi-google 7892cdd
adding test
shubhangi-google 55eb740
test headers
shubhangi-google 7353031
try conformance tests
shubhangi-google c21ea9b
undo conformance
shubhangi-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| require_relative "../storage_helper" | ||
| require 'pry' | ||
|
|
||
| describe "Accept-Encoding" do | ||
| # Inject an array into the middleware instead of using class-level state | ||
| class HeaderRecorder < Faraday::Middleware | ||
| def initialize(app, captured_headers) | ||
| super(app) | ||
| @captured_headers = captured_headers | ||
| end | ||
|
|
||
| def call(env) | ||
| @captured_headers << env.request_headers | ||
| @app.call(env) | ||
| end | ||
| end | ||
|
|
||
| let(:storage) { Google::Cloud::Storage.new } | ||
| let(:captured_headers) { [] } | ||
| let(:client) { storage.service.service.client } | ||
|
|
||
| before do | ||
| # Pass our local captured_headers array to the middleware | ||
| client.builder.insert_before(0, HeaderRecorder, captured_headers) | ||
| end | ||
|
|
||
| after do | ||
| client.builder.delete(HeaderRecorder) rescue nil | ||
| end | ||
|
|
||
| it "does not include Accept-Encoding header on metadata calls" do | ||
| storage.buckets(max: 1) | ||
|
|
||
| refute_empty captured_headers | ||
|
|
||
| # Assert none of the requests included the header | ||
| assert captured_headers.none? { |headers| headers.key?("Accept-Encoding") } | ||
| end | ||
|
|
||
| it "includes Accept-Encoding gzip header on media calls (upload/download)" do | ||
| bucket_name = "gcloud-test-ae-#{Time.now.to_i}-#{SecureRandom.hex(4)}" | ||
| bucket = storage.create_bucket(bucket_name) | ||
|
|
||
| begin | ||
| # Reset our local array instead of calling a class method | ||
| captured_headers.clear | ||
|
|
||
| # Test Upload | ||
| file = bucket.create_file(StringIO.new("hello world"), "test.txt") | ||
| assert_includes captured_headers.map { |h| h["Accept-Encoding"] }, "gzip" | ||
|
|
||
| captured_headers.clear | ||
|
|
||
| # Test Download | ||
| file.download | ||
| assert_includes captured_headers.map { |h| h["Accept-Encoding"] }, "gzip" | ||
| ensure | ||
| # Cleanup | ||
| safe_gcs_execute { file&.delete } | ||
| safe_gcs_execute { bucket&.delete } | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Minitest, it is more idiomatic and readable to use the built-in
must_be_nilexpectation instead ofmust_be :nil?.References