Six small cleanups from a codebase review - #119
Merged
Conversation
TulispValue::Lambda's Display arm wrote the literal "Defun", so `(format "%S" lambda-value)` and error messages mentioning a Lambda value were indistinguishable from a Defun. Print "Lambda" instead.
mark_tail_calls' error already propagates with full context through `?`; the trailing `println!` was a debug stub that landed by accident.
`length` is already cycle-safe (Floyd's tortoise/hare), so the comment claiming tulisp lacks a safe-length helper is no longer accurate. The `length(list)?` call below speaks for itself.
`HashMap::get` needs `&self`, so `gethash` doesn't have to escalate to an exclusive write lock. Under --features sync this dropped a read-only path from `RwLock::write` to `RwLock::read`; under the default build the change is a no-op.
After `% 24` the value is already in [0, 24), so `% 365` is a no-op; after `% 60` the duplicated `% 60` likewise. Behaviour is unchanged but the chains read as a copy-paste artifact.
The Typed arm was guarded by `FromIterator`'s TypeId dispatch (T = TulispObject always landed in Boxed), but the panic violated the no-unwrap/no-panic rule for library code and a future refactor that lost the dispatch shortcut would silently start tripping it. Collect the Vec into a TulispObject list so the conversion stays total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.