Skip to content

fix(deploy): deploys were silent no-ops (hosts: vds never matched) #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shpaker merged 1 commit into from
Jul 8, 2026
Merged

fix(deploy): deploys were silent no-ops (hosts: vds never matched) #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,16 @@ jobs:
echo "tag=latest" >> "$GITHUB_OUTPUT"
fi

- name: ✅ Verify deploy target is configured
env:
DEPLOY_HOST: ${{ vars.DEPLOY_HOST }}
DEPLOY_USER: ${{ vars.DEPLOY_USER }}
run: |
if [ -z "$DEPLOY_HOST" ] || [ -z "$DEPLOY_USER" ]; then
echo "::error::DEPLOY_HOST / DEPLOY_USER repo variables are empty — refusing to run a no-op deploy."
exit 1
fi

- name: 🔑 Set up SSH
run: |
mkdir -p ~/.ssh
Expand Down
5 changes: 4 additions & 1 deletion tmfeed/deploy.playbook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
---
- name: Deploy FeedForBot
hosts: vds
# CI passes the host inline via `-i "<host>,"`, which lands it in the
# implicit `all` group, not `vds`. Targeting `vds` matched no hosts, so
# the playbook was silently skipped and deploys became no-ops.
hosts: all
vars:
feedforbot_token: "{{ lookup('env', 'FEEDFORBOT_TOKEN') }}"
feedforbot_sentry: "{{ lookup('env', 'FEEDFORBOT_SENTRY') | default('', true) }}"
Expand Down
Loading