Fix issues #36 and #38 - #39
Open
hokanosekai wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have corrected a few problems related to the new version of flask.
I updated the issues #36 and #38 related to deprecated methods of flask such as the
_request_ctx_stackandbefore_first_request.For the
_request_ctx_stackand_app_ctx_stack, i replaced it by removing old imports and importcurrent_appfrom flask and update theget_appmethod in consequence by only returning the current_app if it's not None.For the
before_first_request, i remove the concerned line and add the@setupmethoddecorator and a_check_setup_finishedmethod to RBAC class.Now the package is working under flask v3.0.2 and flask-login v0.6.3
This is my first PR on an open-source project, please tell me if i do things wrong 😄