Skip to content

Fix/macos py2app libsharpyuv #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeraz merged 2 commits into from
Jul 20, 2026
Merged

Fix/macos py2app libsharpyuv #587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d6b4a3
Bundle libsharpyuv for macOS py2app build
bwrightkc Jul 20, 2026
0a7d5b0
Re-sign macOS bundle after post-py2app dylib patching
bwrightkc Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions setup_osx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os
import shutil
import sys
from subprocess import call
from subprocess import CalledProcessError, call, check_output

from pysollib.settings import PACKAGE, VERSION

Expand Down Expand Up @@ -36,6 +36,19 @@
SOLVER_LIB_PATH = None
SOLVER = []

# libwebp (a Pillow dependency) depends on libsharpyuv via a bare
# @rpath reference that py2app's dependency walker doesn't follow.
# Bundle it explicitly, same as the solver lib above.
SHARPYUV_LIB_PATH = None
try:
_webp_prefix = check_output(
["brew", "--prefix", "webp"]).decode().strip()
_candidate = os.path.join(_webp_prefix, "lib", "libsharpyuv.0.dylib")
if os.path.exists(_candidate):
SHARPYUV_LIB_PATH = _candidate
except (OSError, CalledProcessError):
pass

GETINFO_STRING = "PySol Fan Club Edition \
%s %s, (C) 1998-2003 Markus F.X.J Oberhumer \
(C) 2006-2007 Skomoroh" % (PACKAGE, VERSION)
Expand All @@ -55,7 +68,8 @@
DATA_FILES = ['docs', 'data', 'locale', 'scripts', 'COPYING', 'README.md',
] + SOLVER
RESOURCES = []
FRAMEWORKS = [SOLVER_LIB_PATH] if SOLVER_LIB_PATH else []
FRAMEWORKS = ([SOLVER_LIB_PATH] if SOLVER_LIB_PATH else []) + \
([SHARPYUV_LIB_PATH] if SHARPYUV_LIB_PATH else [])
# with argv_emulation=True, the app window is not shown when launched
OPTIONS = dict(argv_emulation=False,
emulate_shell_environment=True,
Expand Down Expand Up @@ -84,3 +98,27 @@
@executable_path/../Frameworks/libfreecell-solver.0.dylib fc-solve",
shell=True
)
os.chdir(top)

# Point libwebp at the bundled libsharpyuv instead of its broken
# original rpath.
if SHARPYUV_LIB_PATH and "py2app" in sys.argv:
frameworks_dir = os.path.join(
top, 'dist', '%s.app' % PACKAGE, 'Contents', 'Frameworks')
for name in os.listdir(frameworks_dir):
if name.startswith('libwebp'):
call([
'install_name_tool', '-change',
'@rpath/libsharpyuv.0.dylib',
'@executable_path/../Frameworks/libsharpyuv.0.dylib',
os.path.join(frameworks_dir, name),
])

# install_name_tool invalidates py2app's ad-hoc signature above, and
# macOS refuses to launch a bundle whose seal doesn't match its
# contents. Re-sign after any post-processing.
if (SOLVER or SHARPYUV_LIB_PATH) and "py2app" in sys.argv:
call([
'codesign', '--force', '--deep', '--sign', '-',
os.path.join(top, 'dist', '%s.app' % PACKAGE),
])