Guard prototype chain access to prevent prototype pollution#192
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8e47a6c46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
__proto__,constructor,prototype) when resolving references and assignments.Description
src/compile/prototype-guard.tsthat centralizes prototype-key detection and helpers:hasOwnProperty,isBlockedPrototypeKey, andhasBlockedUnknownPrototypePath.src/compile/references.tsto import the guard and block dangerous top-level or path accesses, including checks before reading context keys, property lookups, index lookups and method invocation, and throw aTypeErroron unsafe method calls.src/compile/set.tsto use the shared guard helpers and remove duplicated prototype-check logic, including blocking unsafe set paths and guarding unknown path resolution.test/references.test.tscovering prototype chain protection scenarios for top-level references,__proto__index/property forms, inheritedconstructor/prototypeexposures, preserving ownconstructor/prototypefields, and function prototype paths.Testing
npm testand the test run completed successfully.prototype chain protectiontests intest/references.test.tspassed as part of the suite.Codex Task