-
Notifications
You must be signed in to change notification settings - Fork 148
fix: block prototype-polluting set paths #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shepherdwind
wants to merge
4
commits into
master
from
codex/fix-prototype-pollution-issue-in-velocityjs
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9bf03f1
fix: block prototype-polluting set paths
shepherdwind 7be7881
fix: validate set paths before assignment values
shepherdwind 13c3749
refactor: clarify set path traversal exit
shepherdwind 09e050d
refactor: keep set path traversal minimal
shepherdwind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a template writes through an ordinary data object that has an own field named
constructororprototype(for example#set($model.constructor.name = 'Car')with{ model: { constructor: {} } }), this early check skips the whole assignment even though it never traversesObject.prototype; the dangerous case is the inheritedconstructor.prototypechain, not every data property with these names. This silently drops valid template updates for contexts that legitimately expose those keys.Useful? React with 👍 / 👎.