Support pinned GitHub Skill metadata#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Allow the optional
metadata.github-pinnedstring that GitHub CLI adds when a Skill is installed withgh skill install --pin.The validator still requires the four standard GitHub source-tracking fields and rejects unknown metadata keys. The regression test now models an actual pinned installation, and the real pinned v1.0.0 installation validates successfully.
Validation
loopctl skill validatepasses against a realgh skill install --pin v1.0.0copyloopctl doctorpassesSummary by cubic
Allow Skills installed with
gh skill install --pinto validate by accepting the optionalmetadata.github-pinnedstring. Validation still requiresgithub-path,github-ref,github-repo, andgithub-tree-sha, rejects unknown keys, and tests now include a pinned install case.Written for commit a596e55. Summary will update on new commits.