Fix Claude plugin loading in v1.0.1#3
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 24 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/skill-package.js">
<violation number="1" location="src/skill-package.js:125">
P2: Skills installed with `gh skill install --pin` still fail validation because GitHub CLI adds `github-pinned` alongside these four source-tracking fields. Treat that optional SHA field as valid GitHub install metadata too.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Comment on lines
+125
to
+127
| const required = ["github-path", "github-ref", "github-repo", "github-tree-sha"]; | ||
| return Object.keys(value).every((key) => required.includes(key)) | ||
| && required.every((key) => typeof value[key] === "string" && value[key].length > 0); |
There was a problem hiding this comment.
P2: Skills installed with gh skill install --pin still fail validation because GitHub CLI adds github-pinned alongside these four source-tracking fields. Treat that optional SHA field as valid GitHub install metadata too.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/skill-package.js, line 125:
<comment>Skills installed with `gh skill install --pin` still fail validation because GitHub CLI adds `github-pinned` alongside these four source-tracking fields. Treat that optional SHA field as valid GitHub install metadata too.</comment>
<file context>
@@ -116,6 +120,13 @@ export function installCanonicalSkill({
+function validGitHubInstallMetadata(value) {
+ if (!value || typeof value !== "object" || Array.isArray(value)) return false;
+ const required = ["github-path", "github-ref", "github-repo", "github-tree-sha"];
+ return Object.keys(value).every((key) => required.includes(key))
+ && required.every((key) => typeof value[key] === "string" && value[key].length > 0);
</file context>
Suggested change
| const required = ["github-path", "github-ref", "github-repo", "github-tree-sha"]; | |
| return Object.keys(value).every((key) => required.includes(key)) | |
| && required.every((key) => typeof value[key] === "string" && value[key].length > 0); | |
| const required = ["github-path", "github-ref", "github-repo", "github-tree-sha"]; | |
| const allowed = new Set([...required, "github-pinned"]); | |
| return Object.keys(value).every((key) => allowed.has(key) && typeof value[key] === "string" && value[key].length > 0) | |
| && required.every((key) => typeof value[key] === "string" && value[key].length > 0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The v1.0.0 manifests passed static validation, but a clean Claude Code installation reported the plugin as installed and failed to load because marketplace and plugin component declarations were merged. A real post-publish install test exposed the discrepancy.
Validation
enabledinstalled, enabledSummary by cubic
Fixes Claude Code plugin load failures on clean installs by enabling strict manifest loading. Rolls the release to v1.0.1 across manifests, schemas, and docs, and adds guardrails to prevent regressions.
Bug Fixes
strict: trueto avoid merged component declarations and ensure the plugin loads.$idURLs now pin tov1.0.1for consistent installs.New Features
SKILL.mdfor installed copies.doctoradds a release check to assert strict Claude manifest loading and version parity.Written for commit 0094a17. Summary will update on new commits.