fix(ci): point report test + smoke-test at committed probe fixture - #9
Merged
Conversation
The report test and the CLI smoke-test loaded harness probe data from packages/harness/results, which is gitignored (results/ rule) and so absent in CI — loadHarnessProbes' statSync threw ENOENT, failing both the test job and build & smoke-test. Add a small frozen fixture (packages/cli/test/fixtures/probes/) and point both at it. Decouples CI from volatile live probe output and keeps live deployment hostnames out of the repo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI run 28326225090 failed on all three jobs (test node 18/20 + build & smoke-test).
Root cause: the report test and the CLI smoke-test load harness probe data from
packages/harness/results, which is gitignored (results/rule inpackages/harness/.gitignore) and therefore absent in CI.loadHarnessProbes'statSyncthrewENOENT.Fix
packages/cli/test/fixtures/probes/(2 files, real-shaped probe records).report.test.tsand the smoke-test step at it instead of the gitignored live results dir.Decouples CI from volatile live probe output and keeps live deployment hostnames out of the repo. Verified locally:
vitest run test/report.test.tspasses (8/8) and the built-binary smoke-test commands exit 0.Not in scope
Publishing the real
packages/harness/resultsas reproducibility artifacts is a separate decision — it would need a scrub pass to placeholder live hostnames (sharted.workers.dev,callback.wulf.shart.cloud) before going public.🤖 Generated with Claude Code