feat: rebasing #216#464
Open
Droid00000 wants to merge 11 commits into
Open
Conversation
+ Rspec tasks (for Ruby 2.7.x, 3.0.x, 3.1.x, 3.2.x) + Rubocop task (with Ruby 2.7.x) + Yard & Github pages tasks (with Ruby 2.7.x) + Update rspec version constraint in discordrb.gemspec (from ~> 3.11.0 to ~> 3.12.0) + Update redcarpet version constraint in discordrb.gemspec (from ~> 3.5.0 to ~> 3.6.0)
Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
Contrary to what the documentation indicated, it was not possible to provide an Array<Overwrite> to Channel#permission_overwrites= It was necessary to provide the Hash similar to what the method Channel#permission_overwrites returns + Added an example file to test the overwrites (I used it as a debug) + Modification of a test in spec/data/channel_spec.rb following this correction
Fix typo and newlines Co-authored-by: Adrien Smith <adrien@panissupraomnia.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebases the PR to keep the one change which is still relevant. This is the last one for tonight