feat: better attachments#455
Open
Droid00000 wants to merge 17 commits into
Open
Conversation
Droid00000
force-pushed
the
feat/attachment-builder
branch
from
5c233f3 to
c52e02f
Compare
Droid00000
force-pushed
the
feat/attachment-builder
branch
from
f767fbf to
685951f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that in multipart uploads, the name of each subpart header is set to an integer, e.g.
0,1, etc. when according to the docs it should instead be something likefiles[0],files[1], etc. I also realized that this would be a good chance to support an attachment builder for messages, since we don't already have one.The commits from the original attachment builder PR builder code were copied into this one.