fix benchmark template#552
Open
Dogacel wants to merge 1 commit into
Open
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Chat template of some models (gpt-oss, qwen3...) are not rendered correctly in SGLang, causing
accuracy to be reported incorrectly.
This patch checks if SGLang consists a template for the given model, if not it handles chat formatting manually using HF tokenizer and sends the templated text directly to SGLang.
Modifications
Also adds 3 new benchmarks:
Related Issues
Fixes #551
Accuracy Test
Tested on 3 model families with different template formats gpt-oss-20b, qwen3 8B, llama3.1 8B.
Any model that reported their accuracy using the previous benchmark should ensure SGLang was able to auto-detect the template. Moreover all models should re-report their GSM8K benchmark results because not applying template correctly causes accuracy drops.
Checklist