fix: pre-beta polish — E2E text mismatches, stale copy, ValidationError, error logging#421
Merged
Merged
Conversation
…or, error logging Fixes several issues found during pre-beta QA audit: - fix(e2e): update 'Continue Watching' -> 'Continue Viewing' assertions - fix(e2e): update 'back to videos' -> 'back to dashboard' assertion - fix(e2e): update empty state text patterns to match actual UI copy - fix(e2e): replace non-existent Series/Channels route tests with Collections/Topics page tests - fix(api): use proper ValidationError tagged class in highlight-reel render route instead of raw object literal - fix(dashboard): rename 'From Your Collections' section to 'Recently Added' to accurately reflect content shown; remove unused getCollections fetch - fix(loading): update stale 'From Your Channels' comment - fix(openapi): update stale 'video collaboration platform' description to Knowledge Hub branding - fix(ui): add error logging in VideoDecisionsSidebar fetch catch block using project logger instead of silent failure Closes #417 #418 #419 #420
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Member
|
@sferadev-bot Seems that playwright is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Beta Polish & QA Audit
This PR addresses findings from a thorough pre-beta QA audit of the Nuclom codebase. Changes are grouped around 4 GitHub issues.
Issues Fixed
Changes
E2E Test Fixes (
tests/e2e/saas/)organization.spec.ts: Update"Continue Watching"→"Continue Viewing"(matches actual page copy); update empty state text pattern; update "From Your Collections" → "Recently Added"upload.spec.ts: Update"back to videos"→"back to dashboard"(matches upload page navigation)videos.spec.ts: Update"Continue Watching"→"Continue Viewing"; fix empty state text pattern to match actual rendered copy; replace non-existent/seriesand/channels/route tests with tests for actual pages (/collections,/topics)API Bug Fix
apps/saas/src/app/(api)/api/highlight-reels/[id]/render/route.ts: Replace raw{ _tag: 'ValidationError' as const, message: '...' }object with propernew ValidationError({ message: '...' })tagged error class instance. This ensures the error is correctly handled bymapErrorToApiResponseand returns a 400 instead of falling through to the generic 500 handler.Dashboard Section Rename
apps/saas/src/app/(org)/org/[organization]/page.tsx: Rename "From Your Collections" section to "Recently Added" with appropriate description. The section was showingvideos.slice(0, 6)(all recent videos) — not collection-filtered content — making the "From Your Collections" title misleading. Also removes the now-unusedgetCollectionsparallel fetch, saving one database query on dashboard load.Stale Copy / Rebrand Fixes
apps/saas/public/openapi.json: Update description from "video collaboration platform" to "Knowledge Hub" brandingapps/saas/src/app/(org)/org/[organization]/loading.tsx: Fix stale{/* From Your Channels section */}comment →{/* From Your Collections section */}Error Logging
apps/saas/src/components/knowledge/video-decisions-sidebar.tsx: Replace silentcatch {}withlogger.error(...)call using the project's@nuclom/lib/client-logger. Decisions are still supplementary (no user-facing error shown), but errors are now observable.Pre-merge Checklist
pnpm --filter nuclom-saas exec tsc --noEmitpasses