make-snapshot action, to make hard copies of project with all deps.#13
Open
avnik wants to merge 9 commits into
Open
make-snapshot action, to make hard copies of project with all deps.#13avnik wants to merge 9 commits into
avnik wants to merge 9 commits into
Conversation
added 8 commits
May 27, 2014 17:50
make-snapshot produce tree with all dependencies included, ready to package to tarball and/or to .src.rpm
I assume that files pulled by script, on 'get-deps'/'update-deps' phase. (this change was added with yokozuna's jars in mind)
because we need to handle errors
Because it return not only sha1 of project, but also url and vcs type
Owner
|
Thanks for posting this! I will make an effort to review in the next couple of days. The idea of using git archive sounds very interesting. |
Author
|
On Wed, May 28, 2014 at 02:01:45PM -0700, Seth Falcon wrote:
Idea was completely borrowed from riak toplevel makefile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I write prototype of locking dependency via copy all stuff from deps/
(using git-archive and hashed taken by same way as regular lock-deps do).
This code heavy inspired by riak Makefile.
Code still need some care from me (add testing, and may be add checking/enforcement all repos to be committed/pushed), but I think I reach point where I need review from someone.