script: update to new XML serializer - #47305
Open
Ms2ger wants to merge 2 commits into
Open
Conversation
Testing: many WPTs now pass Signed-off-by: Ms2ger <Ms2ger@gmail.com>
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#61996) with upstreamable changes. |
Narfinger
reviewed
Aug 18, 2026
Narfinger
left a comment
Narfinger
left a comment
Contributor
There was a problem hiding this comment.
Not that familiar with xml parsing so just style comments.
| ) -> io::Result<()> { | ||
| debug_assert!(!node.is::<Attr>(), "Should have handled Attr in caller"); | ||
| let mut stack = Vec::new(); | ||
| fn push_node( |
Contributor
There was a problem hiding this comment.
I am not a fan of deffining functions in a function. Can we split these out?
| prefix_map: NamespacePrefixMap, | ||
| ) { | ||
| if let Some(template_element) = node.downcast::<HTMLTemplateElement>() { | ||
| for child in template_element.Content(cx).upcast::<Node>().rev_children() { |
Contributor
There was a problem hiding this comment.
Do we have rev_children_unrooted?
| let value = attr.value().clone(); | ||
| (qname, value) | ||
| }) | ||
| .collect(); |
Contributor
There was a problem hiding this comment.
Do we need this collect? It looks like we just take a reference of the value anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
servo/html5ever#772 introduces a new standard-compliant XML serializer. We can no longer reuse the tree walking implementation of the HTML serializer, but reimplement a similar design.
Testing: many WPTs now pass