Skip to content

Fix hostname preservation in file: URLs that contain drive letters - #1127

Merged
Manishearth merged 2 commits into
servo:mainfrom
msrd0:msrd0/fix-hostname-and-drive-letters
Jul 31, 2026
Merged

Fix hostname preservation in file: URLs that contain drive letters#1127
Manishearth merged 2 commits into
servo:mainfrom
msrd0:msrd0/fix-hostname-and-drive-letters

Conversation

@msrd0

@msrd0 msrd0 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #1126

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@25137be). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1127   +/-   ##
=======================================
  Coverage        ?   86.98%           
=======================================
  Files           ?       26           
  Lines           ?     5264           
  Branches        ?        0           
=======================================
  Hits            ?     4579           
  Misses          ?      685           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msrd0
msrd0 force-pushed the msrd0/fix-hostname-and-drive-letters branch from 2529065 to 800b684 Compare June 17, 2026 13:16
@msrd0
msrd0 force-pushed the msrd0/fix-hostname-and-drive-letters branch from 03c3b1f to fd644f1 Compare July 24, 2026 13:45
@Manishearth

Copy link
Copy Markdown
Member

Please address CI issues

@msrd0

msrd0 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@Manishearth should be good now (eventhough it looks like I didn't cause those lints to appear)

@Manishearth
Manishearth added this pull request to the merge queue Jul 31, 2026
Merged via the queue into servo:main with commit 00a6ce5 Jul 31, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Url::parse removes host from Windows-style file URL

2 participants