Run Miri on CI, make tendril compatible with strict provenance - #781
Merged
Conversation
This replaces the `ptr` in `Tendril` with a `NonNull<Header<A>>` instead of a `NonZeroUsize`, making it compatible with miri `MIRIFLAGS=-Zmiri-strict-provenance`.
Signed-off-by: Simon Sapin <simon@igalia.com>
SimonSapin
changed the title
Signed-off-by: Simon Sapin <simon@igalia.com>
This allows running Tendril tests under "cross-compiled" Miri without compiling criterion, which depends on alloca which requires a C toolchain. Signed-off-by: Simon Sapin <simon@igalia.com>
SimonSapin
force-pushed
the
strict-provenance
branch
from
August 24, 2026 16:27
313ec40 to
9d88014
Compare
SimonSapin
changed the title
github-actions
Bot
added
V-breaking
SimonSapin
commented
Aug 24, 2026
|
|
||
| [dev-dependencies] | ||
| rand = { workspace = true } | ||
| criterion = { workspace = true } |
Member
Author
There was a problem hiding this comment.
As dev-dependencies cannot be optional, this allows running Tendril tests under "cross-compiling" Miri without building criterion which depends on alloca which requires a C toolchain
mrobinson
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes servo/tendril#64, which the first commit is based on.