Skip to content

Envelope option were being ignored. #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
May 8, 2026
Merged

Envelope option were being ignored. #1376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions impl/core/src/main/java/io/serverlessworkflow/impl/executors/ListenExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ public static class ListenExecutorBuilder extends RegularTaskExecutorBuilder<Lis

private EventRegistrationBuilderInfo registrationInfo;
private TaskExecutor<?> loop;
private Function<CloudEvent, WorkflowModel> converter =
ce -> application.modelFactory().from(ce.getData());
private final Function<CloudEvent, WorkflowModel> converter;

protected ListenExecutorBuilder(
WorkflowMutablePosition position, ListenTask task, WorkflowDefinition definition) {
Expand All @@ -65,16 +64,10 @@ protected ListenExecutorBuilder(
loop = TaskExecutorHelper.createExecutorList(position, forEach.getDo(), definition);
}
ListenAndReadAs readAs = listen.getRead();
if (readAs != null) {
switch (readAs) {
case ENVELOPE:
converter = ce -> application.modelFactory().from(ce);
default:
case DATA:
converter = ce -> application.modelFactory().from(ce.getData());
break;
}
}
converter =
readAs == ListenAndReadAs.ENVELOPE
? application.modelFactory()::from
: ce -> application.modelFactory().from(ce.getData());
}

protected WorkflowPredicate buildUntilPredicate(Until until) {
Expand Down
Loading