Skip to content

🎨 Palette: Add ARIA labels to TextSharePopover buttons#293

Open
hadsern wants to merge 1 commit into
v2-foundationfrom
palette/add-aria-labels-to-textsharepopover-13189291343392878322
Open

🎨 Palette: Add ARIA labels to TextSharePopover buttons#293
hadsern wants to merge 1 commit into
v2-foundationfrom
palette/add-aria-labels-to-textsharepopover-13189291343392878322

Conversation

@hadsern

@hadsern hadsern commented Apr 19, 2026

Copy link
Copy Markdown
Collaborator

💡 What: Added aria-label attributes to the icon-only buttons in the TextSharePopover component. Also added aria-hidden="true" to the internal <svg> elements.
🎯 Why: To improve keyboard and screen reader accessibility for interactive elements lacking visible text content, ensuring users receive accurate context, especially during dynamic state changes like copying.
📸 Before/After: Visuals remain unchanged; accessibility semantic structure improved.
♿ Accessibility: Improved screen reader support for the text sharing popover.


PR created automatically by Jules for task 13189291343392878322 started by @hadsern

Added descriptive `aria-label` attributes to the icon-only buttons in `TextSharePopover.tsx` (Copy, Share on X, Copy page link) to improve screen reader accessibility. Also added `aria-hidden="true"` to their internal `<svg>` elements to prevent redundant announcements. The `aria-label` for the copy button dynamically mirrors its `title` state ("Copy text" -> "Copied!").

Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant