🎨 Palette: Add ARIA labels to TextSharePopover buttons#293
Conversation
Added descriptive `aria-label` attributes to the icon-only buttons in `TextSharePopover.tsx` (Copy, Share on X, Copy page link) to improve screen reader accessibility. Also added `aria-hidden="true"` to their internal `<svg>` elements to prevent redundant announcements. The `aria-label` for the copy button dynamically mirrors its `title` state ("Copy text" -> "Copied!").
Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
aria-labelattributes to the icon-only buttons in theTextSharePopovercomponent. Also addedaria-hidden="true"to the internal<svg>elements.🎯 Why: To improve keyboard and screen reader accessibility for interactive elements lacking visible text content, ensuring users receive accurate context, especially during dynamic state changes like copying.
📸 Before/After: Visuals remain unchanged; accessibility semantic structure improved.
♿ Accessibility: Improved screen reader support for the text sharing popover.
PR created automatically by Jules for task 13189291343392878322 started by @hadsern