⚡ Bolt: [performance improvement] Pre-index KnowledgeGraph nodes for faster search and filtering#289
Conversation
…faster search and filtering 💡 What: Replaced on-the-fly string lowercasing inside filter and find callbacks with a pre-indexed Map and array of pre-lowercased objects in the KnowledgeGraph component. 🎯 Why: Re-evaluating `.toLowerCase()` repeatedly inside an `onChange` and `onKeyDown` filter loop over large graphs causes excessive main-thread CPU overhead resulting in janky rendering. 📊 Impact: Significantly reduces string conversions from O(N*len) during search to O(N*len) once during map build and O(1) for lookup, increasing performance and eliminating typing lag. 🔬 Measurement: Observe fluid search and exact ID matching in the KnowledgeGraph widget. Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced on-the-fly string lowercasing inside filter and find callbacks with a pre-indexed Map and array of pre-lowercased objects in the KnowledgeGraph component.
🎯 Why: Re-evaluating
.toLowerCase()repeatedly inside anonChangeandonKeyDownfilter loop over large graphs causes excessive main-thread CPU overhead resulting in janky rendering.📊 Impact: Significantly reduces string conversions from O(Nlen) during search to O(Nlen) once during map build and O(1) for lookup, increasing performance and eliminating typing lag.
🔬 Measurement: Observe fluid search and exact ID matching in the KnowledgeGraph widget.
PR created automatically by Jules for task 1378645992789658949 started by @hadsern