Skip to content

🎨 Palette: [UX improvement] TextSharePopover accessibility enhancements#286

Open
hadsern wants to merge 1 commit into
v2-foundationfrom
palette/share-popover-a11y-16789185959304136152
Open

🎨 Palette: [UX improvement] TextSharePopover accessibility enhancements#286
hadsern wants to merge 1 commit into
v2-foundationfrom
palette/share-popover-a11y-16789185959304136152

Conversation

@hadsern

@hadsern hadsern commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

💡 What: Added missing ARIA labels, aria-hidden to SVGs, and visible focus rings to the TextSharePopover icon buttons.
🎯 Why: Icon-only buttons without accessible labels are unintelligible to screen reader users, and without visible focus states, keyboard users cannot tell which button is active.
📸 Before/After: Before, buttons only had title attributes and no focus rings. After, they are fully perceivable to screen readers and visually distinct when tabbed to.
♿ Accessibility: Improved screen reader announcements and keyboard navigation visibility.


PR created automatically by Jules for task 16789185959304136152 started by @hadsern

… popover

Added explicit `aria-label` attributes to the three icon-only buttons (Copy, Twitter, Link) in `TextSharePopover` to match their visible tooltips. Added `aria-hidden="true"` to the inner SVG elements to prevent redundant screen reader announcements. Finally, added visible focus states using the `focus-visible` utility class to ensure keyboard users can track their interaction.

Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant