Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in SchemaScript#282

Open
hadsern wants to merge 1 commit into
v2-foundationfrom
sentinel-xss-fix-13420702072694039658
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in SchemaScript#282
hadsern wants to merge 1 commit into
v2-foundationfrom
sentinel-xss-fix-13420702072694039658

Conversation

@hadsern

@hadsern hadsern commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
πŸ’‘ Vulnerability: XSS vulnerability in SchemaScript when injecting JSON.stringify data into script tags via dangerouslySetInnerHTML. JSON.stringify does not escape HTML control characters like <, >, and &, meaning injected user data could potentially be interpreted as executable HTML/JavaScript.
🎯 Impact: An attacker could potentially inject malicious scripts, leading to Cross-Site Scripting (XSS) attacks.
πŸ”§ Fix: Manually escaped <, >, and & to their unicode equivalents (using literal double backslashes, e.g., \u003c) when serializing JSON for injection into <script> tags in src/components/SchemaScript.tsx. Added a learning entry to .jules/sentinel.md.
βœ… Verification: Ran pnpm test, pnpm build, and verified the changes do not break existing functionality.


PR created automatically by Jules for task 13420702072694039658 started by @hadsern

Added manual escaping for `<`, `>`, and `&` in the `JSON.stringify` output within `SchemaScript.tsx` to prevent Cross-Site Scripting (XSS) vulnerabilities when injecting data into `<script>` tags via `dangerouslySetInnerHTML`. Also appended a corresponding security learning to `.jules/sentinel.md`.

Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant