Skip to content

🎨 Palette: [UX improvement] Add ARIA labels to TextSharePopover buttons#280

Open
hadsern wants to merge 1 commit into
v2-foundationfrom
palette-share-popover-aria-13607100226711857399
Open

🎨 Palette: [UX improvement] Add ARIA labels to TextSharePopover buttons#280
hadsern wants to merge 1 commit into
v2-foundationfrom
palette-share-popover-aria-13607100226711857399

Conversation

@hadsern

@hadsern hadsern commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

💡 What: Added aria-label attributes to the "Copy", "Twitter", and "Share link" buttons in TextSharePopover. Marked their inner <svg> icons with aria-hidden="true".
🎯 Why: These are icon-only buttons. Without ARIA labels, screen readers cannot properly announce their function to users relying on assistive technologies. The aria-hidden attributes prevent the screen reader from redundantly reading out the SVG element.
📸 Before/After: Visually unchanged. Code-level accessibility improvements.
Accessibility:

  • Added dynamic aria-label mirroring the visual title tooltip state changes (e.g. "Copy text" -> "Copied!").
  • Screen readers will now distinctly announce the function of all popover actions.

PR created automatically by Jules for task 13607100226711857399 started by @hadsern

Added missing `aria-label` and `aria-hidden` attributes to the
icon-only buttons inside the `TextSharePopover` component for
improved screen reader accessibility. Ensures dynamic screen
reader announcements mirror tooltip feedback when copying text
or links.

Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant