π‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in JSON-LD script tags#279
π‘οΈ Sentinel: [CRITICAL] Fix XSS vulnerability in JSON-LD script tags#279hadsern wants to merge 1 commit into
Conversation
Manually escape HTML control characters like `<` and `>` to prevent an XSS vector when user input is piped to `JSON.stringify` inside of a `dangerouslySetInnerHTML` call within `SchemaScript`. Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability:
JSON.stringifydoes not automatically escape HTML control characters (<,>,&). TheSchemaScriptcomponent takes this output and injects it into a<script>tag viadangerouslySetInnerHTML. If any schema strings contain</script><script>alert(1)</script>, the JSON stringification would maintain the<and>characters, allowing an attacker to break out of the JSON-LD script block and execute malicious JavaScript on the client.π― Impact: This allows arbitrary JavaScript execution (XSS) on clients loading pages where schema is generated.
π§ Fix: Manually string replace
<and>with their JSON unicode escape equivalents (\\u003cand\\u003e).β Verification:
pnpm test,pnpm lint, andpnpm buildhave successfully run. The generatedschemaJSON output is correctly formatted and escaped.PR created automatically by Jules for task 13016380486855987287 started by @hadsern