🎨 Palette: Add ARIA labels to TextSharePopover buttons#275
Conversation
- Added `aria-label` attributes to the Copy, Twitter/X, and Share link icon-only buttons. - Added `aria-hidden="true"` to the inner `<svg>` elements to prevent redundant screen reader announcements. Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Added
aria-labelattributes andaria-hidden="true"to the icon-only buttons in theTextSharePopovercomponent.🎯 Why
Icon-only buttons require an
aria-labelfor screen reader accessibility so users understand their purpose. Marking the decorative<svg>icons witharia-hidden="true"ensures screen readers do not announce the vector path details redundantly.📸 Before/After
Visually identical (verified with Playwright). See the attached code changes.
♿ Accessibility
Improved screen reader accessibility for the
TextSharePopoverby providing clear contextual labels for the copy, share on X, and copy link actions, and hiding decorative SVGs from the accessibility tree.PR created automatically by Jules for task 52188453110959095 started by @hadsern