Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix ReDoS vulnerability in search scoring#273

Open
hadsern wants to merge 1 commit into
v2-foundationfrom
sentinel-fix-regexp-13809575176820434846
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix ReDoS vulnerability in search scoring#273
hadsern wants to merge 1 commit into
v2-foundationfrom
sentinel-fix-regexp-13809575176820434846

Conversation

@hadsern

@hadsern hadsern commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Passing unescaped user input directly into new RegExp() allows Regular Expression Denial of Service (ReDoS) attacks and crashes via unhandled SyntaxError when given malformed input like *.
🎯 Impact: An attacker could cause the search endpoint (/api/ask) to hang or crash, resulting in a Denial of Service.
πŸ”§ Fix: Replaced the regular expression counting logic with a safe, string-based indexOf loop that handles all string input safely without evaluating regex syntax. Added an empty string check to prevent infinite loops.
βœ… Verification: Ran pnpm test, pnpm lint, and pnpm build successfully. Evaluated indexOf replacement via local test scripts.


PR created automatically by Jules for task 13809575176820434846 started by @hadsern

Replaced unescaped user input passed directly to `new RegExp()` with a safe, string-based `indexOf` loop in `scoreDocument` to prevent Regular Expression Denial of Service (ReDoS) and unhandled SyntaxError crashes.

Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant