π‘οΈ Sentinel: [HIGH] Fix ReDoS vulnerability in search scoring#273
π‘οΈ Sentinel: [HIGH] Fix ReDoS vulnerability in search scoring#273hadsern wants to merge 1 commit into
Conversation
Replaced unescaped user input passed directly to `new RegExp()` with a safe, string-based `indexOf` loop in `scoreDocument` to prevent Regular Expression Denial of Service (ReDoS) and unhandled SyntaxError crashes. Co-authored-by: hadsern <5723837+hadsern@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Passing unescaped user input directly into
new RegExp()allows Regular Expression Denial of Service (ReDoS) attacks and crashes via unhandled SyntaxError when given malformed input like*.π― Impact: An attacker could cause the search endpoint (
/api/ask) to hang or crash, resulting in a Denial of Service.π§ Fix: Replaced the regular expression counting logic with a safe, string-based
indexOfloop that handles all string input safely without evaluating regex syntax. Added an empty string check to prevent infinite loops.β Verification: Ran
pnpm test,pnpm lint, andpnpm buildsuccessfully. EvaluatedindexOfreplacement via local test scripts.PR created automatically by Jules for task 13809575176820434846 started by @hadsern