Add system media controls and Commodore-branded menu bar icon#3
Open
eeksock wants to merge 1 commit into
Open
Conversation
SID Jukebox had no integration with macOS's media control surfaces - Control Center's Now Playing widget, the lock screen, and hardware/ keyboard media keys all had no effect on playback. Wire up MPNowPlayingInfoCenter and MPRemoteCommandCenter: publish the current track's title, artist, duration and elapsed time, and route play/pause/next/previous/stop/seek commands to the existing transport methods. Now Playing info is kept published (title-only, rate 0) even when idle rather than cleared to nil, since a nil entry drops SID Jukebox from macOS's Now Playing arbitration entirely and causes media keys to fall back to launching Apple Music instead. Also replace the generic music-note menu bar icon with the classic Commodore "C=" badge, rendered as a proper template image (1x/2x) so it re-tints correctly for light/dark menu bars and the highlighted state, matching every other status item. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SID Jukebox had no integration with macOS's media control surfaces - Control Center's Now Playing widget, the lock screen, and hardware/keyboard media keys all had no effect on playback.
This wires up
MPNowPlayingInfoCenterandMPRemoteCommandCenter: publishes the current track's title, artist, duration and elapsed time, and routes play/pause/next/previous/stop/seek commands to the existing transport methods.Also replaces the generic music-note menu bar icon with the classic Commodore "C=" badge, rendered as a proper template image (1x/2x) so it re-tints correctly for light/dark menu bars and the highlighted state, matching every other status item. I think it looks great, personally, but feel free to ignore if you prefer the built-in character. :-)