Fix invisible A-Z sort button by forcing Dark Aqua appearance#2
Open
eeksock wants to merge 1 commit into
Open
Conversation
The window and About panel paint a hardcoded dark background but never declared an appearance, so on a system in Light Mode native controls (like the sort NSSegmentedControl) rendered with dark unselected-label text - invisible against the dark background. The selected segment and the toolbar buttons happened to look fine because they draw their own light bezel/pill background. Explicitly set both windows to NSAppearanceNameDarkAqua so native controls render light-on-dark, matching the app's fixed dark theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my screen, the "A-Z" sort button was completely invisible. This was due to the use of hard-coded colors that conflicted with my use of dark mode.
The window and About panel paint a hardcoded dark background but never declared an appearance, so on a system in Light Mode native controls (like the sort NSSegmentedControl) rendered with dark unselected-label text - invisible against the dark background. The selected segment and the toolbar buttons serendipitously were visible only because they draw their own light bezel/pill background.
The fix is to explicitly set both windows to NSAppearanceNameDarkAqua so native controls render light-on-dark, matching the app's fixed dark theme. The application now looks good on my machine, with all controls visible.