Fix shuffle mode replaying tracks and Previous ignoring shuffle order#1
Open
eeksock wants to merge 1 commit into
Open
Fix shuffle mode replaying tracks and Previous ignoring shuffle order#1eeksock wants to merge 1 commit into
eeksock wants to merge 1 commit into
Conversation
nextTrack picked a uniformly random index on every call, which is sampling with replacement rather than a shuffle - tracks could repeat often (even back-to-back) well before the full list had played once. prevTrack also always stepped back by list index regardless of mode, so Previous after a shuffled Next could land somewhere unrelated. Replace this with a proper Fisher-Yates permutation of track indices that is consumed in order by Next and walked backward by Previous, so every track plays once per cycle with no immediate repeats across cycle boundaries. Manual track picks (e.g. double-click) resync the shuffle position so Next/Prev stay consistent afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextTrack picked a uniformly random index on every call, which is sampling with replacement rather than a shuffle. This means that tracks could repeat often (even back-to-back) well before the full list had played once.
Further, prevTrack also always stepped back by list index regardless of mode, so Previous after a shuffled Next could land somewhere unrelated.
Replace this with a proper Fisher-Yates permutation of track indices that is consumed in order by Next and walked backward by Previous, so every track plays once per cycle with no immediate repeats across cycle boundaries. Manual track picks (e.g. double-click) resync the shuffle position so Next/Prev stay consistent afterward.