logic-probe: friendly labels for known census tags - #39
Merged
Conversation
Replace raw 4-letter tags (karT, gRuA, lFuA...) with readable category names from docs/FORMATS.md's tag table. Deliberately does NOT claim the record count equals a real object count for most tags — wit-logic's census module doc measured an ~8.4x record-to-track multiplier on a real project, so that stays disclaimed pending issue #3. The one exception is audio files (lFuA/AuFl), which docs/FORMATS.md measured matching MetaData.plist exactly (35 -> 37) on the one real project checked. Reviewed via /code-review: fixed an overclaim (audio files got the same blanket disclaimer as unverified tags, losing validated signal), removed a dead gnoS mapping entry (root record count can never differ between two successfully-walked files), and added unit tests for the new tag_info() following this file's existing human_bytes() test convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
wit logic-probe's census diff printed raw internal record tags (karT,gRuA,lFuA...) with a blanket "not a musician-facing number" disclaimer. This maps the tagsdocs/FORMATS.mdalready names (tracks, regions, plugins, audio files, MIDI/event sequences) to readable labels, while keeping the underlying honesty guarantee intact — most tags still explicitly say the record count is not the real object count, sincewit-logic's census module doc measured an ~8.4x record-to-track multiplier on a real project.One exception: audio files (
lFuA/AuFl) get a stronger, distinct message, becausedocs/FORMATS.mdmeasured that specific tag matchingMetaData.plist's real count exactly (35 → 37) — the only tag with that evidence. Applying the same generic disclaimer to it would have thrown away a real, verified signal.Reviewed via
/code-reviewbefore landing; that pass caught and fixed:gnoS(root record) mapping entry —wit-logic's frame doc guarantees exactly one root record per valid file, so its count can never differ between two successfully-walked filestag_info()helper, added following this file's existinghuman_bytes()test conventionTested against real project pairs (Ableton
Backup/chain and a real.logicxpair from~/Music/Logic), not just synthetic fixtures.Checklist
docs/numbers changed.gitignore)docs/FORMATS.md; the "not 1:1" disclaimer citeswit-logic's census module docIf this PR changes a number in
docs/N/A — no
docs/numbers changed, this is CLI presentation only.If this PR touches format parsing
N/A — no parsing changed, this only relabels how already-parsed census counts are printed.
🤖 Generated with Claude Code