Fix: unbreak main CI — repo-hygiene docstring section header - #34
Merged
Conversation
reproduce_merge_daw_acceptance.py (PR #31) used the section header "WHAT THIS DOES NOT DO" instead of the exact string tests/test_repo_hygiene.py's test_every_python_experiment_documents_itself requires: "WHAT THIS DOES NOT HANDLE". That test has existed since PR #14 and applies to every file under experiments/ — this PR's own CI run (https://github.com/sep-lab/Wit/actions/runs/31171758303) actually failed on exactly this, in 5 of the 6 Python test jobs. It was merged without that being caught, which is what's currently failing on main. Pure rename, no content change. Verified: full pytest suite (293 passed, 13 skipped, 0 failed), cargo test/clippy/fmt/deny all clean, check_personal_paths.py clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red (5 of the 6 Python test jobs failing). Root cause: PR #31added
experiments/reproduce_merge_daw_acceptance.pywith a section header spelled"WHAT THIS DOES NOT DO" instead of the exact string
tests/test_repo_hygiene.py::test_every_python_experiment_documents_itselfrequires,"WHAT THIS DOES NOT HANDLE" (that check has existed since PR #14 and applies to every
file under
experiments/).This should have been caught before merge — PR #31's own CI run failed on exactly
this (https://github.com/sep-lab/Wit/actions/runs/31171758303), but it was reported as
ready and merged anyway without that being checked. Apologies for the miss; flagging it
plainly rather than glossing over it.
Pure rename, no content or behavior change.
Verification (this branch, full gate)
pytest tests/ -q— 293 passed, 13 skipped, 0 failedcargo test --workspace --locked— all crates passcargo fmt --all --check,cargo clippy --workspace --all-targets --locked -- -D warnings— cleancargo deny check licenses advisories— cleancheck_personal_paths.py— clean🤖 Generated with Claude Code