feat(ci): add Gotenberg integration tests workflow and a version matrix#276
Open
Nitram1123 wants to merge 5 commits into
Open
feat(ci): add Gotenberg integration tests workflow and a version matrix#276Nitram1123 wants to merge 5 commits into
Nitram1123 wants to merge 5 commits into
Conversation
Contributor
|
impressive work. thank you. will take a look soon. |
Nitram1123
force-pushed
the
feat/dagger-integration-tests
branch
from
83eb0b9 to
567e30b
Compare
Nitram1123
force-pushed
the
feat/dagger-integration-tests
branch
from
567e30b to
88cb828
Compare
Jean-Beru
reviewed
May 20, 2026
Jean-Beru
reviewed
May 21, 2026
| } | ||
|
|
||
| /** @var VersionFetcherInterface $versionFetcher */ | ||
| $versionFetcher = static::getContainer()->get(VersionFetcherInterface::class); |
Contributor
There was a problem hiding this comment.
Do you know if the Gotenberg API is called to retrieve its version? It could have a big impact on each test.
Author
There was a problem hiding this comment.
The test case caches the result in a static property ($resolvedGotenbergVersionUnderTest), so the call only happens once per PHPUnit run, not per test.
The service itself also memoizes the response ($this->version ??= …).
And it's only triggered for tests carrying a #[RequiresGotenberg] attribute, so tests without version constraints never hit the network at all.
Nitram1123
force-pushed
the
feat/dagger-integration-tests
branch
from
0493c48 to
f8005cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prepares the integration testing groundwork for issue #158.
It introduces the initial GitHub Actions integration workflow and a matrix to run integration tests against multiple Gotenberg Docker image versions in CI. It also adds a separate nightly latest compatibility check to detect upstream Docker image regressions early. So follow-up PRs can focus on expanding integration coverage.
This is a preparatory step toward adding more integration tests across the bundle’s supported builders and options.
Linked to #158.