feat: Allow to render Twig templates with a specific locale#265
Open
Jean-Beru wants to merge 2 commits into
Open
feat: Allow to render Twig templates with a specific locale#265Jean-Beru wants to merge 2 commits into
Jean-Beru wants to merge 2 commits into
Conversation
Add a `locale(string)` method on builders using Twig (HtmlPdfBuilder, MarkdownPdfBuilder and their Screenshot counterparts) to render content, header and footer templates with the given locale via Symfony's LocaleSwitcher. The current application locale is restored after each rendered template. The `symfony/translation` dependency is optional: when no locale is set, behavior is unchanged. When `locale()` is called without `symfony/translation` installed, a clear LogicException is thrown. The locale is also exposed as a YAML configuration node via WithConfigurationNode so it can be set globally per builder. Original idea by @StevenRenaux. Co-authored-by: Steven Renaux <59167761+StevenRenaux@users.noreply.github.com> Assisted-by: Claude:claude-opus-4-7
Jean-Beru
force-pushed
the
feat/locale-aware-rendering
branch
from
801afaf to
edd2f4b
Compare
StevenRenaux
approved these changes
Apr 30, 2026
Neirda24
reviewed
May 19, 2026
| protected function withRenderedPart(Part $part, string $template, array $context = []): static | ||
| { | ||
| if (null !== $this->locale && $this->getLocaleSwitcher()->getLocale() !== $this->locale) { | ||
| return $this->getLocaleSwitcher()->runWithLocale( |
Contributor
There was a problem hiding this comment.
what about using locale aware instead ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locale(string)method on builders using Twig templates (HtmlPdfBuilder,MarkdownPdfBuilder,UrlPdfBuilderand their Screenshot counterparts) to render content, header and footer templates with the given locale via Symfony'sLocaleSwitcher.locale()is not called:symfony/translationremains an optional dependency. A clearLogicExceptionis thrown iflocale()is called without it installed.WithConfigurationNodeso it can be set globally per builder.Credits
Original idea by @StevenRenaux.