Skip to content

implementation of absolute path for inputs and outputs in Docker + re…#76

Open
paul-csgroup0411 wants to merge 3 commits into
mainfrom
fix-absolute-path
Open

implementation of absolute path for inputs and outputs in Docker + re…#76
paul-csgroup0411 wants to merge 3 commits into
mainfrom
fix-absolute-path

Conversation

@paul-csgroup0411
Copy link
Copy Markdown

…ad me update

Comment thread sen2vm-notebook/src/notebook.ipynb Outdated
"assert os.path.exists(PATH_L1B_DATA), \"L1B path missing\"\n",
"\n",
"os.makedirs(INVERSE_OUTPUT_FOLDER, exist_ok=True)\n",
"assert os.path.exists(INVERSE_OUTPUT_FOLDER), \"Output folder missing\"\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should be launched only when INVERSE is used, not if direct is used

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FRom what I see below, I think there is a missunderstanding.

Sen2VM is writting direct grid directly inside input L1B folder.
But Sen2VM is writting inverse grids in a dedicated output folder. INVERSE_OUTPUT_FOLDER is this folder

Comment thread sen2vm-notebook/src/notebook.ipynb Outdated
"source": [
"# === GIPPs ===\n",
"# This step is optional if the Database was already downloaded or if you want to use your own GIPP\n",
"# If the PATH_GIPP isn't equal to \"\", this cell won't work, if PATH_GIPP= \"\", this cell will clone the git GIPP folder inside WORKDIR/DATA\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I want to download into a dedicated forlder, I can't ?

Either I download it from my side in the folder I want, either I use this cell to download in into WORKING_FOLDER, right ?

Comment thread sen2vm-notebook/README_Notebooks.md Outdated
| ├── DATASTRIP # Required
| ├── GRANULE # Required
| └── ...
│ └── GEOID/ # Put your GEOID files here (Optional)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, we have the GEOID beside the DEM as they are link. COuld it be possible to make it a separate input also ? :)

Comment thread sen2vm-notebook/README_Notebooks.md Outdated
WORKDIR
├── DATA/
│ ├── bulletin*.txt # IERS prediction of earth exploration (downloaded by the cell n°3)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For IERS bulletin, is it complicated to make it also a separate input, but if path is empty, it will download it, and if not, we use the one provided in input ?

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants