feat: standalone desktop mode - #5
Merged
Merged
Conversation
Remember the signed-in user across loopback port changes, bind ticket redeem to the live session store, and stop TypeORM cycles from freezing the login page. Co-authored-by: Cursor <cursoragent@cursor.com>
Return both host candidates from redeem and surface remote Foreseerr entry from the login screen for desktop clients. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hey @selmant, thanks for submitting this PR! However, it looks like the PR template hasn't been fully filled out. Issues found:
Please update your PR description to follow the PR template. This check will automatically re-run when you edit your PR description. |
github-actions
Bot
added
blocked:template
i18n-out-of-sync
|
The i18n check failed because translation messages are out of sync. This usually happens when you've added or modified translation strings in your code but haven't updated the translation file. Please run |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+430
to
+443
| session({ | ||
| secret: settings.sessionSecret, | ||
| resave: false, | ||
| saveUninitialized: false, | ||
| cookie: { | ||
| maxAge: 1000 * 60 * 60 * 24 * 30, | ||
| httpOnly: true, | ||
| path: '/', | ||
| sameSite: | ||
| desktopRuntime || settings.network.csrfProtection ? 'strict' : 'lax', | ||
| secure: desktopRuntime ? false : 'auto', | ||
| }, | ||
| store: sessionStore, | ||
| }) |
| logger.info('Desktop session store is sqlite', { label: 'Server' }); | ||
| server.use('/api', (req, res, next) => { | ||
| const started = Date.now(); | ||
| logger.info(`API ${req.method} ${req.path}`, { label: 'Desktop' }); |
| logger.info(`API ${req.method} ${req.path}`, { label: 'Desktop' }); | ||
| res.on('finish', () => { | ||
| logger.info( | ||
| `API ${req.method} ${req.path} ${res.statusCode} ${Date.now() - started}ms`, |
Comment on lines
+78
to
+83
| session({ | ||
| secret: 'test-secret', | ||
| resave: false, | ||
| saveUninitialized: false, | ||
| store: new session.MemoryStore(), | ||
| }) |
Comment on lines
+107
to
+112
| session({ | ||
| secret: 'test-secret', | ||
| resave: false, | ||
| saveUninitialized: false, | ||
| store: new session.MemoryStore(), | ||
| }) |
Comment on lines
+404
to
+410
| session({ | ||
| secret: 'test-secret', | ||
| resave: false, | ||
| saveUninitialized: false, | ||
| genid: () => 'memory-desktop-session', | ||
| store, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.