Optional addon: make gamepads visible to Steam/Proton and in-desktop browsers#274
Open
h012193213 wants to merge 2 commits into
Open
Conversation
Re-sync browser pads after WebRTC reconnect and recover missing server associations so js events are not dropped. Add optional SELKIES_ENABLE_UINPUT_BRIDGE (off by default) for Steam/Proton and in-desktop browsers that need a real kernel controller, without changing the default LD_PRELOAD interposer path. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
h012193213
changed the title
Member
|
I prefer making Steam / Proton / browsers work in the current architecture, rather. I did find an issue where a refresh of Selkies makes the gamepad disappear (works on html5gamepad.com the first time Selkies is accessed), so let me fix that, first. |
Keep SELKIES_ENABLE_UINPUT_BRIDGE as the supported path and note that legacy socket-only deployments without the flag are out of scope. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dev/inputdevice. This PR adds an optionaladdons/uinput-bridgepath (SELKIES_ENABLE_UINPUT_BRIDGE, off by default) that mirrors pads to a kernel Xbox-like controller when/dev/uinputis available.jsN is not connected). Client re-sync + server recreate/associate recover that without enabling uinput.Addresses #168. Keeps uinput optional per #95 (LD_PRELOAD remains default).
Test plan
SELKIES_ENABLE_UINPUT_BRIDGE: connect over HTTPS, verify gamepad works for LD_PRELOAD apps; refresh/reconnect and confirm buttons still work (nojs0 is not connectedspam).SELKIES_ENABLE_UINPUT_BRIDGE=true,python-evdev, and/dev/uinputaccess: confirm a kernel device appears; restart Steam and verify controller detection; check html5gamepad.com inside the remote desktop./dev/uinput.