refactor: ♻️ include dependency management values, not just in principles#261
Open
lwjohnst86 wants to merge 7 commits into
Open
refactor: ♻️ include dependency management values, not just in principles#261lwjohnst86 wants to merge 7 commits into
lwjohnst86 wants to merge 7 commits into
Conversation
joelostblom
requested changes
May 22, 2026
joelostblom
left a comment
There was a problem hiding this comment.
I don't think I have reviewed this page before so I ended up having several comments.
Mostly, I tried to clarify some of the vaguer value statements claiming that something is "better" by instead specifying how it might be better (feel free to change if you had something else in mind when writing this initially).
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
joelostblom
requested changes
May 22, 2026
joelostblom
requested changes
May 22, 2026
joelostblom
previously approved these changes
May 22, 2026
lwjohnst86
commented
May 22, 2026
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is already a principle about this, but I wanted to include a value about this too, as I think it's important to have at a higher value level given the increasing number of supply chain attacks and risks from AI-generated code.
This PR needs a quick review.
Checklist
just run-all