π‘οΈ Sentinel: [HIGH] Fix default bypasses and hardcoded secrets - #122
π‘οΈ Sentinel: [HIGH] Fix default bypasses and hardcoded secrets#122secrooq wants to merge 1 commit into
Conversation
Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Hardcoded admin bypass secret and Turnstile fallback keys could allow unauthenticated users or bots to bypass critical authentication and anti-spam verification when environment variables are unset.
π― Impact: If
TURNSTILE_SECRET_KEYis omitted, the system defaults to a bypass ("1x...") permitting bots. Similarly, ifADMIN_BYPASS_SECRETis unset, the system defaulted to a hardcoded string ("stealth_dev_bypass_root_2026") that could be discovered, allowing unauthorized bypass of admin MFA in the edge API.π§ Fix:
verifyTurnstilebypasses to rely strictly on non-production environment variables (process.env.NODE_ENV !== "production").verifyTurnstileto fail-closed (return false) when theTURNSTILE_SECRET_KEYis not present instead of using default "1x..." strings.src/auth.ts. It now strictly checksprocess.env.ADMIN_BYPASS_SECRETand fails if it is omitted.β Verification: Verified by running
pnpm run build,pnpm test, andnpx playwright test. Checked that linting passes (with previous acceptable application warnings ignored).PR created automatically by Jules for task 17185414317553584814 started by @secrooq