Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix default bypasses and hardcoded secrets - #122

Open
secrooq wants to merge 1 commit into
mainfrom
sentinel/fix-turnstile-default-bypass-17185414317553584814
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix default bypasses and hardcoded secrets#122
secrooq wants to merge 1 commit into
mainfrom
sentinel/fix-turnstile-default-bypass-17185414317553584814

Conversation

@secrooq

@secrooq secrooq commented Jul 8, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Hardcoded admin bypass secret and Turnstile fallback keys could allow unauthenticated users or bots to bypass critical authentication and anti-spam verification when environment variables are unset.
🎯 Impact: If TURNSTILE_SECRET_KEY is omitted, the system defaults to a bypass ("1x...") permitting bots. Similarly, if ADMIN_BYPASS_SECRET is unset, the system defaulted to a hardcoded string ("stealth_dev_bypass_root_2026") that could be discovered, allowing unauthorized bypass of admin MFA in the edge API.
πŸ”§ Fix:

  • Explicitly set verifyTurnstile bypasses to rely strictly on non-production environment variables (process.env.NODE_ENV !== "production").
  • Refactored verifyTurnstile to fail-closed (return false) when the TURNSTILE_SECRET_KEY is not present instead of using default "1x..." strings.
  • Removed the hardcoded admin TOTP bypass in src/auth.ts. It now strictly checks process.env.ADMIN_BYPASS_SECRET and fails if it is omitted.
    βœ… Verification: Verified by running pnpm run build, pnpm test, and npx playwright test. Checked that linting passes (with previous acceptable application warnings ignored).

PR created automatically by Jules for task 17185414317553584814 started by @secrooq

Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant