🛡️ Sentinel: [CRITICAL] Fix hardcoded NextAuth secret fallback - #107
🛡️ Sentinel: [CRITICAL] Fix hardcoded NextAuth secret fallback#107secrooq wants to merge 1 commit into
Conversation
…igurations. Co-authored-by: secrooq <81346684+secrooq@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🚨 Severity: CRITICAL
💡 Vulnerability: Found a hardcoded
AUTH_SECRETfallback value ("stealth_relay_nextauth_secret_key_edge_v1_2026") used globally in NextAuth initializations withinsrc/auth.tsandsrc/middleware.ts.🎯 Impact: If the
AUTH_SECRETenvironment variable was missing (e.g., misconfigured edge environment), the application would automatically fall back to the known, hardcoded secret. This severely compromises session integrity and allows attackers to forge valid authentication sessions across environments. NextAuth is designed to fail securely if secrets are not provided, but this fallback bypassed that protection.🔧 Fix: Removed the hardcoded fallback assignment in both files. NextAuth will now strictly rely on the environment variable (
getEnv("AUTH_SECRET")). In the event of a missing secret, the application will fail closed rather than failing open with a known public secret. Documented the learning in.jules/sentinel.md.✅ Verification: Verified tests run successfully and the build completes without errors after updating the fallback logic. Unstaged lockfiles to keep the PR clean.
PR created automatically by Jules for task 4719439984369879818 started by @secrooq